Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Existing File checks (Nowackipawel/patch-69) #2447

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Existing File checks (Nowackipawel/patch-69) #2447

merged 2 commits into from
Dec 10, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Dec 9, 2019

Description

Part of this was handled during multi-file upload checks, but this merges the check for upload errors (UPLOAD_ERR_NO_FILE).

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

nowackipawel and others added 2 commits June 24, 2019 14:04
@nowackipawel
Checking file rules for existing files
6951ac1 
max_size, max_dim, is_image, ext_in, mime_in should be checked only if file is uploaded, in other case... rules require file to be available - it is not necessary as long as we have `uploaded` rule.
@MGatner
Merge framework, resolve conflicts
9ed42d8
@lonnieezell lonnieezell merged commit 06caa2c into codeigniter4:develop Dec 10, 2019
@MGatner MGatner deleted the nowackipawel/patch-69 branch December 10, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MGatner @lonnieezell @nowackipawel